feat: Move model from one project to another #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1057 +/- ##
==========================================
+ Coverage 71.83% 71.98% +0.15%
==========================================
Files 160 160
Lines 5087 5111 +24
Branches 547 555 +8
==========================================
+ Hits 3654 3679 +25
+ Misses 1323 1322 -1
Partials 110 110
☔ View full report in Codecov by Sentry. |
Paula-Kli
force-pushed
the
move-model
branch
from
1f768ea to
13951a6
Compare
|
Still missing:
|
Paula-Kli
force-pushed
the
move-model
branch
3 times, most recently
from
d78d9c7 to
9c92dc2
Compare
Paula-Kli
force-pushed
the
move-model
branch
3 times, most recently
from
3bb4ca3 to
fdba987
Compare
dominik003
previously requested changes
Oct 17, 2023
There was a problem hiding this comment.
Nice improvement. Moving toolmodels to another project works fine and everything seems to work fine after moving it. However, there are some backend comments, mostly regarding readability and the use of already existing authentication functions, and a few frontend comments, mostly dealing with potential UI improvements.
frontend/src/app/projects/models/model-description/model-description.component.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/projects/project-detail/model-overview/model-overview.component.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/projects/project-detail/model-overview/move-model/move-model.component.html
Outdated
Show resolved
Hide resolved
frontend/src/app/projects/project-detail/model-overview/move-model/move-model.component.html
Outdated
Show resolved
Hide resolved
frontend/src/app/projects/project-detail/model-overview/move-model/move-model.component.ts
Outdated
Show resolved
Hide resolved
Paula-Kli
force-pushed
the
move-model
branch
2 times, most recently
from
2c014ba to
4839ddd
Compare
frontend/src/app/projects/project-detail/model-overview/model-overview.component.html
Show resolved
Hide resolved
frontend/src/app/projects/project-detail/model-overview/move-model/move-model.component.html
Outdated
Show resolved
Hide resolved
Users might want to move a toolmodel from one project to another without deleting it and all its pipeline before adding it again. This is possible with one simple click.
MoritzWeber0
dismissed
dominik003’s stale review
@dominik003 is out of office
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #799
currently the dialog looks like that:
